Fixes #22971: Spurious test error on the killing of old fiber on datasource save/delete #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
force-pushed
the
bug_22971/spurious_test_error_on_the_killing_of_old_fiber_on_datasource_save_delete
branch
from
320bc9f
to
2c114f9
Compare
VinceMacBuche
approved these changes
Jun 28, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 2c114f9
into
Normation:branches/rudder/7.3
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22971
So the problem seems to be that depending of the timing, when we observe f1 status, it is either still running because init if not done (typically on a slow machine where the foreign datasource answer takes time to be completed) or suspended.
Now, the test check for both status (they are both ok at that point).
I also added a new check that the reloaded datasource fiber is actually live.