Fixes #23112: Add the role-retrieving OIDC feature to OAuth2 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jul 21, 2023
auth-backends/src/main/scala/com/normation/plugins/authbackends/AuthBackendsRepository.scala
Outdated
Show resolved
Hide resolved
…s/AuthBackendsRepository.scala Co-authored-by: Alexis Mousset <alexis.mousset@rudder.io>
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit af5ec9f
into
Normation:branches/rudder/7.3
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23112
The role mapping was only done in a OIDC case, in a
buildUserfunction in the OIDC specializedloadUserfunction.That PR factorize-out the
buildUserfunction to put it into the genericRudderUserServerMappingtrait. That works well because we retrieve group attribute with a function (getAttribute[java.util.ArrayList[String]](reg.roles.attributeName)) that is common to both protocol.The remaining bits are just gluing:
RudderClientRegistrationRepositoryin the trait because it is now required for both, and change class parameters to match itOAuth2andOIDCcase in there respective implementation.Also correct a pair of unrelated typos.