Fixes #22993: Can't deploy, “Configuration state of the object modified by this change request has changed” looping #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by this change request has changed” looping
ElaadF
commented
Jul 28, 2023
| @@ -435,6 +441,15 @@ class TwoValidationStepsWorkflowServiceImpl( | |||
| toFailure(Deployment, changeRequestId, actor, reason) | |||
| } | |||
|
|
|||
| private[this] def stepDeploymentToDeployed( | |||
There was a problem hiding this comment.
This was removed in 7.3 by 3103cf4#diff-98e8dc3343e38546c42491a39303758ad01214ed8e5ef40c6a2c4d85cfa73f8eL413
This is a missing steps, don't understand why it's have been removed
ElaadF
commented
Jul 28, 2023
| @@ -224,7 +225,12 @@ class TwoValidationStepsWorkflowServiceImpl( | |||
| WorkflowAction("Validate", validatorActions) | |||
|
|
|||
| case Deployment.id => | |||
| WorkflowAction("Deploy", deployAction) | |||
| val deploymentAction = { | |||
There was a problem hiding this comment.
3103cf4#diff-98e8dc3343e38546c42491a39303758ad01214ed8e5ef40c6a2c4d85cfa73f8eL205 if think this is a oversight
Without this we cannot close the change-request, the change-request will be deployed, be will still remains in the deployment step
ncharles
approved these changes
Jul 31, 2023
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 7477188
into
Normation:branches/rudder/7.3
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22993
What is the bug
The change-request was blocked in state "deployment" but can be deployed (the changes was deployed even if the change-request is still in the "pending deployment" section. The problem only occurs for pending deployment request, the step valaidation to deployed, is working as expected.
Why it happens
The bug was that it was missing the logic for deployment to deployed part
The bug is only present in 7.3 due to 3103cf4 the logic was removed
How can I validate that the fix is working ?