Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23278: Improve some messages in the interface - plugins #588

Merged
merged 1 commit into from Aug 16, 2023
Merged

Fixes #23278: Improve some messages in the interface - plugins #588

merged 1 commit into from Aug 16, 2023

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from ElaadF August 15, 2023 13:44
@amousset
Copy link
Member Author

PR updated with a new commit

1 similar comment
@amousset
Copy link
Member Author

PR updated with a new commit

fanf
fanf reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm (and wow!)

@amousset
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/588
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/72342/console)

@amousset
Copy link
Member Author

OK, squash merging this PR

@amousset amousset force-pushed the enh_23278/improve_some_messages_in_the_interface_plugins branch from a111f3d to bfc01a6 Compare August 16, 2023 08:26
@amousset amousset merged commit 41c9f8d into Normation:branches/rudder/8.0 Aug 16, 2023
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf left review comments

@ElaadF ElaadF ElaadF approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
4 participants
@amousset @Normation-Quality-Assistant @fanf @ElaadF