Fixes #23254: User management plugin incorrectly understand OIDC roles #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated with a new commit |
2 similar comments
|
PR updated with a new commit |
|
PR updated with a new commit |
VinceMacBuche
approved these changes
Aug 21, 2023
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
bug_23254/user_management_plugin_incorrectly_understand_oidc_roles
branch
from
e7163a1
to
293fa7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23254
A first PR for the problematic of dynamic role. This one is done so that it is compatible with current Rudder 7.3 and so we don't have the real configuration option for OIDC role override. So we just add a generic warning message to avoid surprise.
This PR also correct the fact that the list of authentication providers is hard coded in user management (to provide human readable version ?) and that authentication provider out of that not-maintained list are IGNORED.
At some point, we will have a type for providers, with their properties (does it override roles, etc), but we should never ignore unknown providers! I just removed the types, because they would likely be something else.
This was why OIDC was not listed and so user got false information.
Message:
