Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23348: not allowed to access errors because rudder plugins are missing AuthorizationApiMapping #596

Conversation

fanf
Copy link
Member

@fanf fanf commented Aug 24, 2023

https://issues.rudder.io/issues/23348

Use the new facility provided by Normation/rudder#5004 to declare rights along with the API schema. Correct a bunch of API rights which were using the default one (Administrator.Write) in place of something less powerful (often Administration.Read)

For change validation:

  • the dedicated api right mapper is not useful anymore,
  • it was missing ValidatedUser in the list of aggregated endpoints, which was causing specific additional problems.

@fanf
Copy link
Member Author

fanf commented Aug 30, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/596
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/72992/console)

@fanf
Copy link
Member Author

fanf commented Sep 1, 2023

OK, squash merging this PR

@fanf fanf force-pushed the bug_23348/not_allowed_to_access_errors_because_rudder_plugins_are_missing_authorizationapimapping branch from 155324a to 79ff5fd Compare September 1, 2023 10:20
@fanf fanf merged commit 79ff5fd into Normation:7.3-next Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants