Fixes #12905: Create validation workflows plugins #61
Conversation
|
PR rebased |
fanf
force-pushed
the
arch_12905/create_validation_workflows_plugins
branch
from
a66bccb
to
acd155c
Compare
|
PR rebased |
fanf
force-pushed
the
arch_12905/create_validation_workflows_plugins
branch
from
acd155c
to
fb9f562
Compare
|
PR rebased |
fanf
force-pushed
the
arch_12905/create_validation_workflows_plugins
branch
from
fb9f562
to
b06746c
Compare
changes-validation/Makefile
Outdated
|
|
||
| include ../makefiles/common-scala-plugin.mk | ||
|
|
||
| target/$(NAME)/changes-validation-schema.sql: |
There was a problem hiding this comment.
The file is not present and will prevent build of the plugin for now
| ************************************************************************************* | ||
| */ | ||
|
|
||
| /* add you plugin css in that file */ |
There was a problem hiding this comment.
Do we need to keep that file ?
I don't think so and i would remove it and remove it from the html
| ************************************************************************************* | ||
| */ | ||
|
|
||
| /* add you plugin JS content here */ |
| <div id="plugin-main" data-lift="surround?with=common-layout;at=content"> | ||
| <head_merge> | ||
| <title>Rudder :: Changes Validation</title> | ||
| <link rel="stylesheet" type="text/css" href="/toserve/changesvalidation/changes-validation.css" media="screen" data-lift="with-cached-resource"> |
There was a problem hiding this comment.
I think it could be removed and line below too (see comment on css file)
| case Some(cr) => changeRequestChangesSerialisation.serialise(cr) | ||
| case None => Full(NodeSeq.Empty) | ||
| } | ||
| if(xml.toString().contains(code)) { |
There was a problem hiding this comment.
Can we ckeck we are in production or in dev run mode of Lift ? to prevent enabling it by default on production :)
There was a problem hiding this comment.
Actually, we don't really want to keep it in the released version :)
main-build.conf
Outdated
| parent-plugin=1.3 | ||
| parent-plugin-version=${rudder-branch}-${parent-plugin} | ||
|
|
||
| lib-common=1.2 |
|
This PR is not mergeable to upper versions. |
1 similar comment
|
This PR is not mergeable to upper versions. |
fanf
force-pushed
the
arch_12905/create_validation_workflows_plugins
branch
from
b06746c
to
5e713b6
Compare
|
PR rebased |
|
It misses the sql file in src main resources, makefile will fail |
|
or remove the makefile entry |
fanf
force-pushed
the
arch_12905/create_validation_workflows_plugins
branch
from
5e713b6
to
d7d0f24
Compare
|
PR rebased |
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/12905