Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23775: Migrate api-authorizations, auth-backends to zio-json #612

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Nov 23, 2023

https://issues.rudder.io/issues/23775

Migrating api-authorizations, there needed to be a rewrite of the lift-json serializer into a data transfer case class and the added tests ensures that the display/hiding of the token value is the same after migrating to zio-json...

Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some little things to change, but that's a super nive evolution in our code base, GG.
It can be merged once the remark are addressed.

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory clarktsiory force-pushed the arch_23775/migrate_api_authorizations_auth_backends_to_zio_json branch from 3b15d10 to e931686 Compare November 24, 2023 09:54
@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/612
-- Your faithful QA
Kant merge: "Thoughts without content are empty, intuitions without concepts are blind."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/76607/console)

@fanf
Copy link
Member

fanf commented Nov 29, 2023

OK, squash merging this PR

@fanf fanf force-pushed the arch_23775/migrate_api_authorizations_auth_backends_to_zio_json branch from e931686 to 120deab Compare November 29, 2023 17:34
@fanf fanf merged commit 120deab into Normation:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants