Fixes #23907: List change requests with additional filters #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
force-pushed
the
enh_23907/list_change_requests_with_additional_filters
branch
from
1c9f885
to
5424345
Compare
|
PR rebased |
fanf
approved these changes
Jan 5, 2024
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
1 similar comment
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/23907
Adding the
ruleId,directiveIdandnodeGroupIdquery params filter support for listing change requests.I fixed compilations issues along the way (missing type declaration for implicits).
There exists repository methods to
getByRuleetc. but the state is queried with a pattern :LIKE 'Pending%'in SQL. In the end the result is the same as when passing explicit state values :IN ('Pending deployment', 'Pending validation'), I preferred the latter to also avoid conflicts when refactoring fromBoxtoIOResult