Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12936: Missing select all/none by categories #64

Conversation

fanf
Copy link
Member

@fanf fanf commented Jul 11, 2018

@fanf
Copy link
Member Author

fanf commented Jul 11, 2018

PR rebased

@fanf fanf force-pushed the bug_12936/missing_select_all_none_by_categories branch from 36c7e8e to 30fd2a7 Compare July 11, 2018 15:28
@fanf
Copy link
Member Author

fanf commented Jul 11, 2018

PR rebased

@fanf fanf force-pushed the bug_12936/missing_select_all_none_by_categories branch from 30fd2a7 to 0078f0d Compare July 11, 2018 16:14
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Your branch is up-to-date with 'NRM/branches/rudder/4.3'.
Already up-to-date.
Deleted branch 4.3_test (was 99a4b30).
Merge made by the 'recursive' strategy.
[...]
Running merge tests
 $ cd "/var/lib/quality-assistant/rudder-plugins" && ./qa-test --merge

-- stderr --
From github.com:fanf/rudder-plugins
 * [new branch]      bug_12936/missing_select_all_none_by_categories -> bug_12936/missing_select_all_none_by_categories_pr
Switched to branch 'branches/rudder/4.3'
Switched to a new branch '4.3_test'
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-plugins/pull/64 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA

@fanf
Copy link
Member Author

fanf commented Jul 18, 2018

OK, merging this PR

@fanf fanf merged commit 0078f0d into Normation:branches/rudder/4.3 Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants