Fixes #24114: Migrate user-management API to zio-json #643
Conversation
|
PR updated with a new commit |
user-management/pom-template.xml
Outdated
| <dependency> | ||
| <groupId>javax.servlet</groupId> | ||
| <artifactId>servlet-api</artifactId> | ||
| <version>2.5</version> |
There was a problem hiding this comment.
don't we use:
<groupId>javax.servlet</groupId>
<artifactId>javax.servlet-api</artifactId>
<version>3.1.0</version>
<scope>provided</scope>
In other projects, we should/need to homogeneize that. Perhaps we should just put it in the parent pom since it seems we need it everywhere.
There was a problem hiding this comment.
Totally ! We used 3.1.0 as well when migrating other plugins
I don't know where I copied that from...
✅ 63834f6
|
PR updated with a new commit |
|
PR updated with a new commit |
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_24114/migrate_user_management_api_to_zio_json
branch
from
25f9c97
to
5eedb39
Compare
https://issues.rudder.io/issues/24114
Remove the code dependency on lift-json. That makes this PR the last of the series of migrating to zio-json on rudder-plugins !
There are some uncommon json response structures (objects with nesting e.g.
{"reload":{"status":"Done"}}) that are not really used by the Elm. It introduces superfluous case classes for serialisation but this can be changed later.