Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24293: change validation plugin documentation refers to Rudder 5.0 #674

Merged
merged 1 commit into from Feb 29, 2024
Merged

Fixes #24293: change validation plugin documentation refers to Rudder 5.0 #674

merged 1 commit into from Feb 29, 2024

Conversation

ncharles
Copy link
Member

@ncharles ncharles requested a review from fanf February 29, 2024 15:57
fanf
fanf approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/674
-- Your faithful QA
Kant merge: "It is beyond a doubt that all our knowledge begins with experience."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/80768/console)

@ncharles
Copy link
Member Author

OK, merging this PR

2 similar comments
@ncharles
Copy link
Member Author

OK, merging this PR

@ncharles
Copy link
Member Author

OK, merging this PR

@ncharles ncharles merged commit 2d07867 into Normation:branches/rudder/7.3 Feb 29, 2024
9 checks passed
@ncharles
Copy link
Member Author

OK, merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
4 participants
@ncharles @Normation-Quality-Assistant @fanf @amousset