Fixes #24434: Fix UI issues caused by bootstrap update in user-management and auth-backends plugin #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
force-pushed
the
bug_24434/fix_ui_issues_caused_by_bootstrap_update_in_user_management_plugin
branch
from
897630e
to
fccdc7a
Compare
clarktsiory
changed the title
RaphaelGauthier
approved these changes
Mar 18, 2024
|
OK, merging this PR |
Normation-Quality-Assistant
merged commit 5d02af5
into
Normation:branches/rudder/8.1
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24434
Mainly the user management cards in the dashboard are impacted by bootstrap 5 upgrade : the
rowclass is no longer needed.Along with that the login page also uses classes which were renamed / render differently in bootstrap 5, now we have :