Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24630: External reports tab is not aligned in nodes page and content is always displayed #702

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fixes #24630: External reports tab is not aligned in nodes page and content is always displayed #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...cala/com/normation/plugins/nodeexternalreports/extension/CreateNodeDetailsExtension.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,17 @@ class CreateNodeDetailsExtension(externalReport: ReadExternalReports, val status
val e = eb ?~! "Can not display external reports for that node"
("External reports", <div class="error">{e.messageChain}</div>)
case Full(config) =>
(config.tabTitle, <div id="externalReport">{tabContent(config.reports)(myXml)}</div>)
(config.tabTitle, <div id="externalReport" class="tab-pane" role="tabpanel">{tabContent(config.reports)(myXml)}</div>)
}

(
"#NodeDetailsTabMenu *" #> { (x: NodeSeq) =>
x ++ (
<li class="ui-tabs-tab"><a href="#externalReport">{tabTitle}</a></li>
<li class="nav-item">
<button class="nav-link" data-bs-toggle="tab" data-bs-target="#externalReport" type="button" role="tab" aria-controls="externalReport">{
tabTitle
}</button>
</li>
)
} &
"#node_logs" #> { (x: NodeSeq) =>
Expand Down