Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24848: Impact on user management: missing get with new param #711

Conversation

fanf
Copy link
Member

@fanf fanf commented May 7, 2024

@fanf fanf requested a review from clarktsiory May 7, 2024 12:32
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/711
-- Your faithful QA
Kant merge: "Morality is not the doctrine of how we may make ourselves happy, but how we may make ourselves worthy of happiness."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/84222/console)

@clarktsiory
Copy link
Contributor

OK, merging this PR

1 similar comment
@clarktsiory
Copy link
Contributor

OK, merging this PR

@clarktsiory clarktsiory merged commit 482ae48 into Normation:branches/rudder/7.3 May 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants