Fixes #24996: UpdateHttpDatasetTest datasource test get blocked forever #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24996
So, there was two problems:
try
inattempt
leads to stalling testsWe had that:
And in case of exception, it was not doing what was expected but failing with the exception. It might be due to a change in the way
ZIO.attempt
works (since we switched to 2.x around here), but how the hell didn't we caught it before ? Or is it a more recent change in 2.X branch ? (but then, the last upgrade is in 08/2023 on 8.0 branch)..toString
in the fallback case, so all values, even when they were map (ie json objects), were changed into string, so quote espacted, then parsed back AS STRING. Which obviously does not work.And that leads to two questions:
JSONAware
stopped to be able to castLinkedArrayList
toJSONObject
, when did it happened (since we don't seems to have change json path version in all 8.0 live).toString
was added ? It seems to have always been there - since 2019 at least.So that's more question than solution. IT REALLY STRANGE and it will be good to find the root change that lead to that.