Fixes #12274: Rudder-tests offline #112
Conversation
platforms/FDA.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
We may not need this one in the repo 😆
|
Commit modified |
Fdall
force-pushed
the
bug_12274/rudder_tests_offline
branch
from
3847703
to
e01185a
Compare
rtf
Outdated
| return use_proxy | ||
| except socket.error as e: | ||
| print("Network unreachable, can only start local already set up vms") | ||
| return use_proxy |
There was a problem hiding this comment.
You removed use_proxy = "" and indented the return
rtf
Outdated
| @@ -298,7 +301,18 @@ class Vagrant(Host): | |||
| def start(self): | |||
| """ Setup and run this host """ | |||
| proxy = have_proxy() | |||
| os.system(proxy + "vagrant up " + self.hostid + " --provider="+self.provider) | |||
| if (proxy==None): | |||
There was a problem hiding this comment.
I'd say this is over engineered, the empty proxy variable is sufficient for all the cases
|
Commit modified |
Fdall
force-pushed
the
bug_12274/rudder_tests_offline
branch
from
e01185a
to
a62a4f5
Compare
| except socket.error as e: | ||
| print("Network unreachable, can only start local already set up vms") | ||
| use_proxy="" | ||
| return use_proxy |
| @@ -298,6 +304,15 @@ class Vagrant(Host): | |||
| def start(self): | |||
| """ Setup and run this host """ | |||
| proxy = have_proxy() | |||
| if (proxy==""): | |||
| command = "vagrant status " + self.hostid | |||
There was a problem hiding this comment.
i don't understand what this is for
There was a problem hiding this comment.
When offline we can only try to start a group of machines that are shutdown.
This ensure the requested vms are just in poweroff mode and not in the need to be installed completely.
There was a problem hiding this comment.
proxy is not empty only when you are offline
You may use a specific proxy value for this, but doesn't vagrant already tell you this when you just try a vagrant up ?
|
there are conflicts, you need to run rudder-dev rebase |
|
Will close this PR, it is not a useful feature and it needs some time to merge with 2fc892d |
https://www.rudder-project.org/redmine/issues/12274