Fixes #13556: another typo in rtf #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Sep 21, 2018
rtf
Outdated
| @@ -333,7 +333,7 @@ class Vagrant(Host): | |||
| proxy = have_proxy() | |||
| while "making sure that no vagrant up are running": | |||
| (returncode, output) = shell("pgrep -f \"vagrant up\"", fail_exit=False) | |||
| if returncode != 0: | |||
| if returncode != 1: | |||
There was a problem hiding this comment.
you mean vagrant up should return 1 in case of succes ? that doesn't look unix
There was a problem hiding this comment.
it is pgrep that returns 1 when no process are found: https://www.gsp.com/cgi-bin/man.cgi?section=1&topic=pgrep
There was a problem hiding this comment.
ok so the original ==0 was right
peckpeck
approved these changes
Sep 21, 2018
Fdall
force-pushed
the
ust_13556/another_typo_in_rtf
branch
from
dcd7c97
to
5e3dccc
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/13556