Fixes #14703: Let rtf execute tests from a given ncf PR #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Apr 19, 2019
rtf
Outdated
| @@ -115,6 +115,7 @@ Commands | |||
| Setup the given platform, install ncf from git in the specified version and then run the ncf tests. | |||
| When no cfengine version is specified, tests will be executed with the cfengine agent shipped with the | |||
| Rudder agent in the same version than the ncf version specified. | |||
| You can also test a give ncf pull request by remplacing the version parameter by the redmine number, like #14641 | |||
There was a problem hiding this comment.
beware, # in a command line is a comment, can't we have something else ?
peckpeck
reviewed
Apr 19, 2019
scenario/lib.py
Outdated
| try: | ||
| if live_output: | ||
| print("+" + command) | ||
| if hostname == 'localhost': | ||
| return check_output("LANG=C " + command, shell=True) | ||
| return ("0", check_output("LANG=C " + command, shell=True)) |
There was a problem hiding this comment.
i think the return code should be an integer
|
Commit modified |
3 similar comments
|
Commit modified |
|
Commit modified |
|
Commit modified |
|
PR rebased |
Fdall
force-pushed
the
ust_14703/let_rtf_execute_tests_from_a_given_ncf_pr
branch
from
e352a0f
to
dcc5352
Compare
|
Commit modified |
peckpeck
reviewed
May 2, 2019
| @@ -22,6 +22,7 @@ Usage: | |||
| rtf scenario doc <scenario> | |||
| rtf scenario env <platform> | |||
| rtf scenario ncf_tests <platform> <version> [--cfengine-version=<cfengine_version>] | |||
| rtf scenario ncf_tests <platform> <pull-request-number> [--cfengine-version=<cfengine_version>] | |||
|
Commit modified |
peckpeck
approved these changes
May 2, 2019
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
ust_14703/let_rtf_execute_tests_from_a_given_ncf_pr
branch
from
cf9bad9
to
a8c5c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14703