Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #14938: Patching network.sh for debian10 broke it for older OS #164

Merged
merged 1 commit into from May 22, 2019
Merged

Fixes #14938: Patching network.sh for debian10 broke it for older OS #164

merged 1 commit into from May 22, 2019

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented May 22, 2019

@Normation-Quality-Assistant
Copy link

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 68899b9 into Normation:master May 22, 2019
peckpeck
peckpeck reviewed May 22, 2019
View reviewed changes
scripts/network.sh
then
cat /etc/debian_version | grep -q "10\."
retcode=$?
if [ "$retcode" = "0" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 lines for this:
if grep -q "10." /etc/debian_version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peckpeck peckpeck peckpeck left review comments

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
3 participants
@Fdall @Normation-Quality-Assistant @peckpeck