Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16772: Add an upgrade scenario in rtf #194

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Feb 20, 2020

rtf Outdated Show resolved Hide resolved
@@ -0,0 +1,28 @@
"""
Scenario: base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name doesn't match

scenario/upgrade.py Outdated Show resolved Hide resolved
test_shell_on("server", '/usr/local/bin/rudder-setup upgrade-server 6.0-nightly', error_mode=Err.CONTINUE, live_output=True)
# Update API token and re-test the webapp
(rudder_url, token) = scenario.platform.api_connection_info()
os.environ['RUDDER_TOKEN'] = token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many other variables set by rtf are not set here, I think that you should put the code in common

@Fdall
Copy link
Contributor Author

Fdall commented Feb 21, 2020

PR updated with a new commit

@Fdall Fdall requested a review from peckpeck March 5, 2020 10:35
@Normation-Quality-Assistant

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_16772/add_an_upgrade_scenario_in_rtf branch from 07ebaa4 to 12fa2c3 Compare March 6, 2020 17:06
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 12fa2c3 into Normation:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants