Fixes #7602: rudder-dev self upgrade #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
added a commit
that referenced
this pull request
Dec 16, 2015
Fixes #7602: rudder-dev self upgrade
| @@ -178,6 +183,8 @@ except ImportError: | |||
|
|
|||
|
|
|||
| ## GLOBAL VARIABLES | |||
| RUDDER_DEV_ORIGIN = "http://www.rudder-project.org/tools/rudder-dev" | |||
There was a problem hiding this comment.
in term of security, this is DISASTROUS - any man in the middle, anywhere between the user and our server can modify, tamper or replace the file - this has been a vector of attack recently from hacked router which replaced content of http to inject malware. Here I can't even imagine the impact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7602