Fixes #7702: Create files to hold release informations #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge, this is a PR to discuss the file format and structure. |
| @@ -0,0 +1,17 @@ | |||
| # Release data file | |||
|
|
|||
| # Supported architecture for each distribution | |||
There was a problem hiding this comment.
Format:
- comments allowed
- key=value allowed without "" around key
- { "key": "value" } allowed
|
I like the file format overall. It's natural and easy to read. |
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
9c13140
to
4fe4c57
Compare
| # Release data file | ||
|
|
||
| # Supported architecture for each distribution | ||
| ARCHITECTURE = { "debian-5": [ "i386", "amd64" ], |
There was a problem hiding this comment.
Actually, I think this key name is not great - this is a list of OS -> arches paris, not really just architectures.
How about os_architectures or something similar ?
There was a problem hiding this comment.
OK, after discussion, architecture is fine. But we should use architectures like roles and packages.
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
4fe4c57
to
79bc424
Compare
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
79bc424
to
a6b28fe
Compare
| freebsd = { | ||
| aliases = [ ] | ||
| package-format = "" | ||
| } |
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
a6b28fe
to
2561868
Compare
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
2561868
to
74410c5
Compare
| "agent-allinone": [ "rudder-agent" ], | ||
| "agent-thin": [ "rudder-agent-thin" ], | ||
| "relay": [ "rudder-server-relay" ], | ||
| "server": [ "rudder-inventory-endpoint", "rudder-jetty", "rudder-reports", "rudder-server-root", "rudder-webapp", "rudder-techniques", "ncf", "ncf-api-virtualenv" ], |
There was a problem hiding this comment.
This list is missing rudder-inventory-ldap in all versions
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
74410c5
to
07c097c
Compare
|
PR updated |
peckpeck
force-pushed
the
ust_7702/create_files_to_hold_release_informations
branch
from
07c097c
to
e8f50c2
Compare
jooooooon
added a commit
that referenced
this pull request
Dec 30, 2015
…elease_informations Fixes #7702: Create files to hold release informations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7702