Fixes #7837: Rudder-dev is misleading when it prints an API url #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should remove display of api Url, and only keep a line like: "Creating pull request" (or imo, event better ... "Creating pull request ... Done" So I'll remove that print and only keep print(comment) |
|
All commands by rudder-dev are printed to make it easy to understand, debug and repeat. I'd like something here that indicates us what it does and how to redo it if needed. |
VinceMacBuche
added a commit
that referenced
this pull request
Jan 26, 2016
…ng_when_it_prints_an_api_url Fixes #7837: Rudder-dev is misleading when it prints an API url
peckpeck
deleted the
bug_7837/rudder_dev_is_misleading_when_it_prints_an_api_url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7837