Fixes #9240: Repository addition in rudder-setup fails when lsb_release is unavailable on Debian like OSes #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Oct 6, 2016
| if [ -e /etc/debian_version ]; then | ||
| ${PM_INSTALL} lsb-release | ||
| elif [ -e /etc/centos-release ] || [ -e /etc/redhat-release ]; then | ||
| ${PM_INSTALL} redhat-lsb-core |
There was a problem hiding this comment.
We do not really need it, so I think we should not install it.
…se is unavailable on Debian like OSes
Kegeruneku
force-pushed
the
bug_9240/repository_addition_in_rudder_setup_fails_when_lsb_release_is_unavailable_on_debian_like_oses
branch
from
7a99a0c
to
7830004
Compare
|
Commit modified |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9240