Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9654: rudder-dev typo #248

Conversation

peckpeck
Copy link
Member

@peckpeck
Copy link
Member Author

ping @amousset

@peckpeck
Copy link
Member Author

PR rebased

- patch the file
- commit with git
- call rudder dev commit
ex: rudder-dev typo README "Typo in readme"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change example to "rudder-dev quickfix"

# open a typo issue then and link it
def quick_fix_pr(pr_url, trigraph=None, merge=False):
pr = PR(pr_url)
issue = Issue("9661")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoded issue ? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overwritten below, you can remove it

pr = PR(pr_url)
issue = Issue("9661")
# find PR
pr = PR(pr_url)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two "pr = PR(pr_url)"

@peckpeck
Copy link
Member Author

Commit modified

@Normation-Quality-Assistant

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit afafe71 into Normation:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants