New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #9654: rudder-dev typo #248
Fixes #9654: rudder-dev typo #248
Conversation
ping @amousset |
PR rebased |
5796703
to
1982150
Compare
- patch the file | ||
- commit with git | ||
- call rudder dev commit | ||
ex: rudder-dev typo README "Typo in readme" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change example to "rudder-dev quickfix"
# open a typo issue then and link it | ||
def quick_fix_pr(pr_url, trigraph=None, merge=False): | ||
pr = PR(pr_url) | ||
issue = Issue("9661") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoded issue ? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overwritten below, you can remove it
pr = PR(pr_url) | ||
issue = Issue("9661") | ||
# find PR | ||
pr = PR(pr_url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two "pr = PR(pr_url)"
1982150
to
afafe71
Compare
Commit modified |
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/9654