Fixes #11794: quality assistant should merge approved PR #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
peckpeck
force-pushed
the
ust_11794/quality_assistant_should_merge_approved_pr
branch
from
c8ec19e
to
3be0998
Compare
VinceMacBuche
requested changes
Nov 30, 2017
| api_url = "https://api.github.com/repos/Normation/{repo}/pulls/{id}/reviews" | ||
| url = api_url.format(repo=repo, id=data["number"]) | ||
| status = {} | ||
| for review in github_call(url): |
There was a problem hiding this comment.
I would reorganize:
reviews = github_call(url)
if len(reviews) == 0:
skip (no review)
else:
for review in reviews:
status[review['user']['login']] = review['state']
if "CHANGE_REQUESTED" in status.values:
reassign
else:
if freeze:
skip (freeze)
else:
merge
There was a problem hiding this comment.
This has also a side effect of reassing at every run (but don't know if it's a problem though)
|
Commit modified |
peckpeck
force-pushed
the
ust_11794/quality_assistant_should_merge_approved_pr
branch
from
3be0998
to
c8a87e0
Compare
peckpeck
force-pushed
the
ust_11794/quality_assistant_should_merge_approved_pr
branch
from
c8a87e0
to
bacc584
Compare
|
Commit modified |
VinceMacBuche
approved these changes
Dec 4, 2017
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11794