Fixes #4455: Add the postgresql-recovery script #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| read CONFIRMATION | ||
|
|
||
| if [ ! "z${CONFIRMATION}" = "zY" ]; then |
There was a problem hiding this comment.
The zY techniques is used to protect from empty strings as "" does.
Using both is redundant.
Kegeruneku
force-pushed
the
bug_4455/int/4455_add_postgresql_recovery_script
branch
from
c3f2779
to
59e8dd9
Compare
|
Updated according to review ! |
|
|
||
| read FOLDER | ||
|
|
||
| echo "\nBackuping to ${FOLDER}. Press Y to continue or any key to abort." |
|
OK looks good to me |
Kegeruneku
force-pushed
the
bug_4455/int/4455_add_postgresql_recovery_script
branch
from
59e8dd9
to
770397f
Compare
|
Oops, a bit late ! |
peckpeck
added a commit
that referenced
this pull request
Apr 3, 2015
…l_recovery_script Fixes #4455: Add the postgresql-recovery script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/4455
To be merged in master