Fixes #18013: Automating Rudder installation and configuration via Ansible #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Jul 20, 2020
| @@ -0,0 +1,147 @@ | |||
| #!/usr/bin/python | |||
| # -*- coding: utf-8 -*- | |||
| # This file is part of Ansible | |||
amousset
reviewed
Jul 20, 2020
| # You should have received a copy of the GNU General Public License | ||
| # along with Ansible. If not, see <http://www.gnu.org/licenses/>. | ||
| # | ||
| # Copyright: (c) 2019, Rémi REY (@rrey) |
There was a problem hiding this comment.
didn't pay attention to the whole description part, i'm on it
There was a problem hiding this comment.
Copyright: (c) 2020, Normation SAS
amousset
reviewed
Jul 20, 2020
| __metaclass__ = type | ||
|
|
||
|
|
||
| class RudderLdapSettigsInterface(object): |
There was a problem hiding this comment.
Not related to LDAP, can you rename it?
amousset
reviewed
Jul 20, 2020
| __metaclass__ = type | ||
|
|
||
|
|
||
| class RudderSettigsInterface(object): |
There was a problem hiding this comment.
Suggested change
| class RudderSettigsInterface(object): | |
| class RudderSettingsInterface(object): |
amousset
reviewed
Jul 20, 2020
| VALUE = response.get("data") | ||
| return VALUE.get("settings").get(name) | ||
|
|
||
| def Set_SettingValue(self, name, value): |
There was a problem hiding this comment.
Suggested change
| def Set_SettingValue(self, name, value): | |
| def set_SettingValue(self, name, value): |
amousset
requested changes
Jul 20, 2020
| state: present | ||
| become: true | ||
|
|
||
| - name: redhat | Adding Rudder Repo |
There was a problem hiding this comment.
does not look like a redhat config as it calls zypper
amousset
reviewed
Jul 27, 2020
|
|
||
| rudder_version: 6.1 | ||
|
|
||
| rudder_depo: repository.rudder.io |
There was a problem hiding this comment.
Suggested change
| rudder_depo: repository.rudder.io | |
| rudder_repo: repository.rudder.io |
|
I dunno if we should keep this PR or not @amousset (i think we changed wuite a few things here, especially since we have some playbooks published now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18013