Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #22892: declared compatibility in 7.2 is misleading #761

Merged
merged 1 commit into from Aug 25, 2023
Merged

Fixes #22892: declared compatibility in 7.2 is misleading #761

merged 1 commit into from Aug 25, 2023

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck requested a review from amousset June 15, 2023 07:42
fanf
fanf reviewed Jul 24, 2023
View reviewed changes
release-data/rudder-7.3.cson Outdated
@@ -121,7 +121,7 @@ api-version = {
}

# Agent versions you can use with this version's server
compatible-agents = [ "7.2", "7.3" ]
compatible-agents = [ "6.2", "7.0", "7.1", "7.2", "7.3" ]
Copy link
Member

@fanf fanf Jul 24, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7.3 is only compatible with 7.1, 7.2, 7.3 and 8.0

fanf
fanf reviewed Jul 24, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
@@ -116,7 +116,7 @@ api-version = {
}

# Agent versions you can use with this version's server
compatible-agents = [ "7.2", "7.3", "8.0" ]
compatible-agents = [ "7.0", "7.1", "7.2", "7.3", "8.0" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0 will be only compatible 7.3 and 8.0 (and latter on 8.1)

@peckpeck
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link

This PR breaks qa-test

-- stdout -- 
Branch 'master' set up to track remote branch 'master' from 'NRM'.
Your branch is up to date with 'NRM/master'.
Already up to date.
Your branch is up to date with 'NRM/master'.
[...]
+ read -r file
+ shellcheck --format gcc ./scripts/ec2-rudder-server-4-components/install-script-rudder-front.sh
+ grep ' error: '
+ true
+ IFS=
+ read -r file
+ shellcheck --format gcc ./scripts/rudder-compliance/rudder-compliance
+ grep ' error: '
+ exit 1

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-tools/pull/761 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/72664/console)

@peckpeck
Copy link
Member Author

OK, squash merging this PR

@peckpeck peckpeck force-pushed the bug_22892/declared_compatibility_in_7_2_is_misleading branch from bb54ad6 to 7058ac2 Compare August 25, 2023 07:24
@peckpeck
Copy link
Member Author

OK, merging this PR

1 similar comment
@peckpeck
Copy link
Member Author

OK, merging this PR

@peckpeck peckpeck merged commit 7058ac2 into Normation:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

@amousset amousset Awaiting requested review from amousset

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
3 participants
@peckpeck @Normation-Quality-Assistant @fanf