Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #23505: Add sales-tier data to release-data #778

Merged
merged 1 commit into from Oct 6, 2023
Merged

Fixes #23505: Add sales-tier data to release-data #778

merged 1 commit into from Oct 6, 2023

Conversation

peckpeck
Copy link
Member

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-7.0.cson Outdated
"ubuntu-14.04": { "i386": "tier3", "amd64": "tier3" },
"ubuntu-15.10": { "i386": "tier3", "amd64": "tier3" },
"ubuntu-16.04": { "i386": "tier2", "amd64": "tier2" },
"ubuntu-18.04": { "amd64": "tier1" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we have a i386 tiers2 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't build it

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-7.0.cson Outdated
"ubuntu-16.04": { "i386": "tier2", "amd64": "tier2" },
"ubuntu-18.04": { "amd64": "tier1" },
"ubuntu-20.04": { "amd64": "tier1" },
"rhel-5": { "i386": "tier4", "amd64": "tier4" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have that in the spreadsheet, it should be
"rhel-3": { "i386": "tier4", "amd64": "tier4" },
"rhel-5": { "i386": "tier3", "amd64": "tier3" },

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-7.0.cson Outdated
"rhel-6": { "i386": "tier3", "amd64": "tier3" },
"rhel-7": { "i386": "tier3", "amd64": "tier1", "ppc64le": "tier1" },
"rhel-8": { "amd64": "tier1", "ppc64le": "tier1" },
"sles-11" : { "i386": "tier2", "amd64": "tier2" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have
"sles-10" : { "i386": "tier4", "amd64": "tier4" },

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-7.1.cson
@@ -89,6 +89,37 @@ tier1 = [
"slackware-14.1", "slackware-14.2",
]

# see https://docs.google.com/spreadsheets/d/1MbpYDH5Eqmgj1j-G4Gu0oKQoBaiGhjUfwVY5qtXTsu4/edit#gid=0
sales-tier = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not commenting here, the same as 7.0 should apply (and extra os added during 7.1)

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-7.2.cson
@@ -91,6 +91,39 @@ tier1 = [
"slackware-14.1", "slackware-14.2",
]

# see https://docs.google.com/spreadsheets/d/1MbpYDH5Eqmgj1j-G4Gu0oKQoBaiGhjUfwVY5qtXTsu4/edit#gid=0
sales-tier = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
# see https://docs.google.com/spreadsheets/d/1MbpYDH5Eqmgj1j-G4Gu0oKQoBaiGhjUfwVY5qtXTsu4/edit#gid=0
sales-tier = {
"debian-6": { "i386": "tier3", "amd64": "tier3" },
"debian-7": { "i386": "tier3", "amd64": "tier3" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian 6 & 7 are both tiers4

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
sales-tier = {
"debian-6": { "i386": "tier3", "amd64": "tier3" },
"debian-7": { "i386": "tier3", "amd64": "tier3" },
"debian-8": { "i386": "tier3", "amd64": "tier3", "armhf": "tier3", "arm64": "tier3" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian 8 arm is tiers4

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
"debian-6": { "i386": "tier3", "amd64": "tier3" },
"debian-7": { "i386": "tier3", "amd64": "tier3" },
"debian-8": { "i386": "tier3", "amd64": "tier3", "armhf": "tier3", "arm64": "tier3" },
"debian-9": { "i386": "tier2", "amd64": "tier2", "armhf": "tier2", "arm64": "tier2" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debian 9 arm is tiers4, and i386amd64 is tiers3

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
"ubuntu-24.04": { "amd64": "tier1" },
"rhel-6": { "i386": "tier3", "amd64": "tier3" },
"rhel-7": { "i386": "tier3", "amd64": "tier2", "ppc64le": "tier3" },
"rhel-8": { "amd64": "tier1", "ppc64le": "tier2" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ppc64 for rhel8 & 9 is tier3

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson
"ubuntu-20.04": { "amd64": "tier1" },
"ubuntu-22.04": { "amd64": "tier1" },
"ubuntu-24.04": { "amd64": "tier1" },
"rhel-6": { "i386": "tier3", "amd64": "tier3" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is rhel5 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we stopped building it

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson
"rhel-7": { "i386": "tier3", "amd64": "tier2", "ppc64le": "tier3" },
"rhel-8": { "amd64": "tier1", "ppc64le": "tier2" },
"rhel-9": { "amd64": "tier1", "ppc64le": "tier2" },
"al-2023": { "amd64": "tier1" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is AL2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is in rhel7

ncharles
ncharles reviewed Sep 29, 2023
View reviewed changes
release-data/rudder-8.0.cson Outdated
"rhel-8": { "amd64": "tier1", "ppc64le": "tier2" },
"rhel-9": { "amd64": "tier1", "ppc64le": "tier2" },
"al-2023": { "amd64": "tier1" },
"sles-11" : { "i386": "tier3", "amd64": "tier3" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have a sles10 tiers4 also

@peckpeck
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the arch_23505/add_sales_tier_data_to_release_data branch from 6058312 to d6c3805 Compare October 6, 2023 09:22
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit d6c3805 into Normation:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@peckpeck @Normation-Quality-Assistant @ncharles