New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7347: Add rudder-dev revert #98
Fixes #7347: Add rudder-dev revert #98
Conversation
PR updated |
b349794
to
99796c4
Compare
url = "https://api.github.com/repos/Normation/{repo}/issues/{pr_id}/events" | ||
pr_events = github_request(url, None, pr_url) | ||
pr_merged = [ pr for pr in pr_events if pr["event"] == "merged" ] | ||
if len(pr_merged) == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be !=1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's possible to have more that one 'merged' event ... I guess there should be only one and should be as you said!
99796c4
to
fcab476
Compare
PR updated |
PR updated |
fcab476
to
97f744a
Compare
- Revert pull request merge commit | ||
- if retarget, merge it to next branch with ours strategy (keep changes in next branch) | ||
ex: rudder-dev revert 1234 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 blank lines instead of one
Fixes #7347: Add rudder-dev revert
https://www.rudder-project.org/redmine/issues/7347