Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7347: Add rudder-dev revert #98

Merged

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

PR updated

url = "https://api.github.com/repos/Normation/{repo}/issues/{pr_id}/events"
pr_events = github_request(url, None, pr_url)
pr_merged = [ pr for pr in pr_events if pr["event"] == "merged" ]
if len(pr_merged) == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be !=1 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's possible to have more that one 'merged' event ... I guess there should be only one and should be as you said!

@VinceMacBuche
Copy link
Member Author

PR updated

@VinceMacBuche
Copy link
Member Author

PR updated

- Revert pull request merge commit
- if retarget, merge it to next branch with ours strategy (keep changes in next branch)
ex: rudder-dev revert 1234

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 blank lines instead of one

peckpeck added a commit that referenced this pull request Nov 17, 2015
@peckpeck peckpeck merged commit 940c8ec into Normation:master Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants