Fixes #19873: Saving a rule with deleted directives/groups does not c…

…orrect it
Normation · Aug 27, 2021 · 25b9a98 · 25b9a98
1 parent cdb7068
commit 25b9a98
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/webapp/sources/rudder/rudder-web/src/main/elm/rules/sources/ViewTabContent.elm b/webapp/sources/rudder/rudder-web/src/main/elm/rules/sources/ViewTabContent.elm
@@ -151,9 +151,22 @@ tabContent model details isNewRule=
           buildListRow ids =
             let
               --Get more information about directives, to correctly sort them by displayName
-              directives = model.directives
-                |> List.filter (\d -> List.member d.id ids)
-                |> List.sortWith (compareOn .displayName)
+              directives =
+                let
+                  knownDirectives = model.directives
+                    |> List.filter (\d -> List.member d.id ids)
+                    |> List.sortWith (compareOn .displayName)
+                  in
+                    -- add missing directives
+                    let
+                      knonwIds = List.map .id knownDirectives
+                    in
+                      List.append
+                        knownDirectives
+                        (ids
+                          |> List.filter (\id -> not (List.member id knonwIds) )
+                          |> List.map (\id -> (Directive id ("Missing directive with ID "++id.value) "" "" "" False False ""))
+                        )
 
               rowDirective  : Directive -> Html Msg
               rowDirective directive =