Fixes #24665: Number of nodes in rule badge is not correct with tenants

Normation · Apr 3, 2024 · e988d7e · e988d7e
1 parent 5f7b785
commit e988d7e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/...s/rudder/rudder-core/src/main/scala/com/normation/rudder/domain/policies/RuleTarget.scala b/...s/rudder/rudder-core/src/main/scala/com/normation/rudder/domain/policies/RuleTarget.scala
@@ -337,7 +337,15 @@ object RuleTarget extends Loggable {
           // here, if we don't find the group, we consider it's an error in the
           // target recording, but don't fail, just log it.
           case GroupTarget(groupId)         =>
-            nodes ++ groups.getOrElse(groupId, Chunk.empty)
+            val groupNodes = groups.getOrElse(groupId, Chunk.empty)
+            val filtered   = {
+              if (allNodesAreThere) groupNodes
+              else {
+                val keys = Chunk.fromIterable(allNodes.keys)
+                groupNodes.filter(keys.contains(_))
+              }
+            }
+            nodes ++ filtered
 
           case TargetIntersection(targets) =>
             val nodeSets     = targets.map(t => getNodeIdsChunkRec(Chunk(t), allNodes, groups, allNodesAreThere))

diff --git a/...dder/rudder-core/src/main/scala/com/normation/rudder/repository/NodeGroupRepository.scala b/...dder/rudder-core/src/main/scala/com/normation/rudder/repository/NodeGroupRepository.scala
@@ -358,7 +358,7 @@ object RoNodeGroupRepository {
       targets:          Set[RuleTarget],
       arePolicyServers: MapView[NodeId, Boolean]
   ): Chunk[NodeId] = {
-    RuleTarget.getNodeIdsChunk(targets, arePolicyServers, allGroups)
+    RuleTarget.getNodeIdsChunk(targets, arePolicyServers, allGroups, false)
   }
 }