Merge pull request #151 from VinceMacBuche/bug_3382/Machine_Inventory…

…_on_rudder_installation Fixes #3382 : Handle Missing machine inventory in NodeInfoService
Normation · Apr 2, 2013 · fa1d96b · fa1d96b
2 parents 82302d5 + ca34208
commit fa1d96b
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/rudder-core/src/main/scala/com/normation/rudder/services/nodes/NodeInfoService.scala b/rudder-core/src/main/scala/com/normation/rudder/services/nodes/NodeInfoService.scala
@@ -110,9 +110,17 @@ class NodeInfoServiceImpl(
       node <- con.get(nodeDit.NODES.NODE.dn(nodeId.value), nodeInfoAttributes:_*) ?~! "Node with ID '%s' was not found".format(nodeId.value)
       nodeInfo <- for {
                     server <- con.get(inventoryDit.NODES.NODE.dn(nodeId.value), nodeInfoAttributes:_*)  ?~! "Node info with ID '%s' was not found".format(nodeId.value)
-                    machineId <- inventoryDit.MACHINES.MACHINE.idFromDN(new DN(server(A_CONTAINER_DN).get))
-                    machine <- con.get(inventoryDit.MACHINES.MACHINE.dn(machineId),Seq("*"):_*)
-                    nodeInfo <- ldapMapper.convertEntriesToNodeInfos(node, server,Some(machine))
+                    machine <- server(A_CONTAINER_DN) match {
+                      case Some(container) => inventoryDit.MACHINES.MACHINE.idFromDN(new DN(container)) match {
+                        case Full(machineId) =>  Full(con.get(inventoryDit.MACHINES.MACHINE.dn(machineId),Seq("*"):_*).toOption)
+                        case eb:EmptyBox => val msg = s"could not get machine from container ${container} : ${eb}"
+                          logger.error(msg)
+                          Failure(msg)
+                      }
+                      case None => logger.debug(s"no machine Inventory for ${server}")
+                        Full(None)
+                    }
+                    nodeInfo <- ldapMapper.convertEntriesToNodeInfos(node, server,machine)
                   } yield {
                     nodeInfo
                   }