Fixes #7689: Error on promise generation after accepting a node #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,6 +458,7 @@ trait ComposedNewNodeManager extends NewNodeManager with Loggable { | |||
| case Full(seq) => //ok, cool | |||
| logger.info(s"New node accepted and managed by Rudder: ${id.value}") | |||
| cacheToClear.foreach { _.clearCache } | |||
| updateDynamicGroups.startManualUpdate | |||
There was a problem hiding this comment.
this is pretty much adding back https://github.com/Normation/rudder/pull/986/files#diff-fb9876df49b189786ae8f6c12bb71679L454
There was a problem hiding this comment.
Maybe cache building should trigger an update of groups ! But great ! Thanks ncharles
amousset
added a commit
that referenced
this pull request
Dec 24, 2015
…ration_after_accepting_a_node Fixes #7689: Error on promise generation after accepting a node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7689