Fixes #7634: Make NodeInfo more dependant on Node #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated |
VinceMacBuche
force-pushed
the
arch_7634/make_nodeinfo_more_dependant_on_node
branch
from
426309c
to
069eae5
Compare
| val id = node.id | ||
| val name = node.name | ||
| val description = node.description | ||
| //val creationDate = node.creationDate |
There was a problem hiding this comment.
Why do you remove creationDate, nodeReportingConfiguration and properties which are not in Node ?
There was a problem hiding this comment.
OK, at least creationDate (not sure the other two are actually used)
|
PR updated |
VinceMacBuche
force-pushed
the
arch_7634/make_nodeinfo_more_dependant_on_node
branch
from
069eae5
to
a22b054
Compare
fanf
added a commit
that referenced
this pull request
Jan 12, 2016
…ore_dependant_on_node Fixes #7634: Make NodeInfo more dependant on Node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7634