Fixes #7753: Improve description of compliance mode #1026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amousset I already improved this text in the 3.2 branch. I agree this could be improved back in 3.0, but why don't you take the same text, at least as a working base? Then we can improve it everywhere. |
|
I had not noticed it had been changed in 3.2, I will use the new version as working base. |
amousset
force-pushed
the
ust_7753/improve_description_of_compliance_mode
branch
from
5988e75
to
3d737a0
Compare
|
PR updated |
|
In fact maybe it would be worthwhile you going through other changes from that same PR and selecting any other improved texts you think would benefit 3.0/3.1 ? |
|
Yes, preparing another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7753