Fixes #4282: Directive migration doesn't handle default values #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -254,8 +250,8 @@ class Section2FieldService(val fieldFactory: DirectiveFieldFactory, val translat | |||
| for { | |||
| nameValues <- seqOfNameValues | |||
| } yield { | |||
| val valueOpt = try Some(nameValues.values(i)) catch { case e: Exception => None } | |||
| (nameValues.name, valueOpt) | |||
| val valueOpt = try Some(nameValues.values(i)) catch { case e: Exception => nameValues.name.constraint.default } | |||
There was a problem hiding this comment.
I want to try some refactoring here before merging
|
PR updated |
VinceMacBuche
force-pushed
the
bug_4282/directive_migration_doesn_t_handle_default_values
branch
from
d52068b
to
fcf379d
Compare
VinceMacBuche
force-pushed
the
bug_4282/directive_migration_doesn_t_handle_default_values
branch
from
fcf379d
to
ae412fe
Compare
|
PR updated |
| // A section will be defined as a Map of value by variable name | ||
| // * ie: Map(A -> Seq("A1", "A2"), B -> Seq("B1", "B2")) => Seq( Map((A -> "A1"), (B -> "B1")) | ||
| // , Map((A -> "A2"), (B -> "B2")) ) | ||
| // If there is no value, a Section with default value is returned is returned |
|
Closing, replacing by a better idea |
|
See #1046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/4282