Fixes #8246: Node configuration cache is invalidated too often #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -439,10 +439,13 @@ trait DeploymentService_buildNodeConfigurations extends DeploymentService with L | |||
| , globalSystemVariables: Map[String, Variable] | |||
| ): Map[NodeId, InterpolationContext] = { | |||
|
|
|||
| println(s"**** AGAIN ${allNodeInfos.size} nodes in allNodeInfos, check exists:\n *** ${List("06da3556-5204-4bd7-b3b0-fa5e7bcfbbea","009e0af1-1a3c-4ee0-a91d-10b68a008f5d", "073239d7-c633-4b60-8477-57131839fd34").map( k => (k, allNodeInfos.isDefinedAt(NodeId(k)))).mkString("\n *** ")}") | |||
There was a problem hiding this comment.
What is this line doing :o
Are the hard-coded nodeIds not just for debug?
There was a problem hiding this comment.
drunk @fanf is drunk ;) I think it's debug / dev logger that need to be removed ... or changed as logger.trace without hardcoded ids ...
There was a problem hiding this comment.
Pay attention to the Balmer Peak!
https://xkcd.com/323/
There was a problem hiding this comment.
It was debug. The nodes in the list had specific interesting properties, like "no policy server", "policy server id not a known node", "policy server a known node (which don't know it is a policy server)"
|
apart the print it's ok to me and can be merged ! |
|
PR updated |
fanf
force-pushed
the
bug_8246/node_configuration_cache_is_invalidated_too_often
branch
from
37af5f6
to
ad4ac0b
Compare
fanf
deleted the
bug_8246/node_configuration_cache_is_invalidated_too_often
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8246