Fixes #8250: Redesigning the Login Page #1089
Conversation
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
f115d00
to
37ce1d5
Compare
| <link href="/images/themes/ui-lightness/jquery.ui.all.css" rel="stylesheet" type="text/css" /> | ||
| <link rel="stylesheet" href="/bootstrap-3.2.0-dist/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.4.0/css/font-awesome.min.css"> | ||
| <link rel="stylesheet" href="https://code.ionicframework.com/ionicons/2.0.1/css/ionicons.min.css"> |
There was a problem hiding this comment.
Hi. Do you really want to include code on the login page from the internet? What about environments, where there is no internet available for the Browser you are using the Rudder UI?... might happen...
There was a problem hiding this comment.
Hi. You are right this is a bad idea, I am going to change that !
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
37ce1d5
to
65336db
Compare
| <link href="/style/ionicons-2.0.1/css/ionicons.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/AdminLTE.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/skin-yellow.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/perso.css" rel="stylesheet" type="text/css"> |
There was a problem hiding this comment.
I don't find this file in the diff, can you remove it please ? or add its content if needed to login.css / or rename it to custom.css
|
Ho and can you put a screenshot here of the new login screen please? :) |
|
Can you remove non minified css files (font-awesome and ionicon) ? |
|
Do you need 'less' and 'scss' files ? if not, remove them :) |
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
65336db
to
7aa02e2
Compare
|
Can we only keep only svg/png we use from ionicons ? We don't need all I think !! also can you remove rudder-web/src/main/webapp/style/ionicons-2.0.1/.gitignore |
|
Not for now, but ion icons will be used for the next menu design. But for the moment I can still remove them if you want ? |
|
If they will be used then do not remove them ... do you knwo which one will not be used ? |
|
Here is an overview of the new login screen !
|
|
Not exactly, but I can remove icons that I'm sure to never use. |
|
Nice. I have to modify my apache rewrite rule to customize it... For reference: https://www.rudder-project.org/redmine/issues/6661 |
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
7aa02e2
to
ea2a298
Compare
| <link href="/bootstrap-3.2.0-dist/css/bootstrap.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/font-awesome-4.6.2/css/font-awesome.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/ionicons-2.0.1/css/ionicons.min.css" rel="stylesheet" type="text/css"> | ||
| <link href="/style/login.min.css" rel="stylesheet" type="text/css"> |
There was a problem hiding this comment.
Sorry to bug you, but will the login.css be minimized to login.min.css during the build?
Just asking because down below you commit the login.css and login.min.css, and the login.css is not referenced there :-o
There was a problem hiding this comment.
This will not be minified during build ( a part of my infinite todo list ...)
@RaphaelGauthier We should not use minified file for our code, because we will forget a some time to minify after fixes (or at least I will forget :) )
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
ea2a298
to
0d714d4
Compare
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
0d714d4
to
f0a851c
Compare
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
f0a851c
to
8dd2d20
Compare
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
8dd2d20
to
cbdbc5a
Compare
RaphaelGauthier
force-pushed
the
ust_8250/redesigning_the_login_page
branch
from
cbdbc5a
to
2e4b436
Compare
|
PR updated |
|
Here is the latest version of the new login screen :
|
|
It would be nice to have a place where we can put custom information, for example "Use your AD account"... |
|
Something like this ?
|
|
Well, more like making Welcome, please sign in a configurable value in the webapp config file, and you keep that (2-3 line?) area customizable, but defaulting to your current text. So you can have there like |
|
And if we are already on "how could this be improve", please have a look at this: |
|
Thanks @matya For all your feedback and ideas ;) I think the customization will go with http://www.rudder-project.org/redmine/issues/6661 and I'll add you comment in this issue ! |
https://www.rudder-project.org/redmine/issues/8250