Fixes #8359: Redesigning the main menu #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8359/redesigning_the_main_menu
branch
from
83a8f2d
to
4f34e85
Compare
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8359/redesigning_the_main_menu
branch
from
4f34e85
to
dcf5bc5
Compare
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8359/redesigning_the_main_menu
branch
from
dcf5bc5
to
9e6fdde
Compare
| @@ -77,11 +80,12 @@ class BootstrapMenu { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| <ul class="nav navbar-nav"> | |||
| <ul class="sidebar-menu"> | |||
There was a problem hiding this comment.
All the html should be in common-layout (in fact the part with the version should be in common-layout.html)
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8359/redesigning_the_main_menu
branch
from
9e6fdde
to
8a3f203
Compare
| @@ -0,0 +1,590 @@ | |||
| /* | |||
There was a problem hiding this comment.
Can you move that file into /style/rudder ? We want Rudder specific file into the same directory !
There was a problem hiding this comment.
@RaphaelGauthier Can you move that file in another directory ? /style/rudder ? use 'git mv' command to move it!
|
PR updated |
RaphaelGauthier
force-pushed
the
ust_8359/redesigning_the_main_menu
branch
from
8a3f203
to
40d7251
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8359