Fixes #8534: Add an technique API endpoint to display directives based on a technique #1117
Conversation
| directive <- directives | ||
| if ( versions match { | ||
| case None => true | ||
| case Some(versions) => versions.contains(directive.techniqueVersion) |
There was a problem hiding this comment.
would be clearer to not override versions variable name
|
<3 this will make life easier. |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8534/add_an_technique_api_endpoint_to_display_directives_based_on_a_technique
branch
from
41079a3
to
51458d4
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8534/add_an_technique_api_endpoint_to_display_directives_based_on_a_technique
branch
from
51458d4
to
43aa519
Compare
|
The two endpoints works as advertised, but I find it very hard to use them without an "index" endpoint in /techniques/, which would just output techniques -> [versions] for example. Would it be hard to add ? |
|
Well, or you need to have a rudder UI open, which is a little sad for an API ;( |
|
(oups) |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8534/add_an_technique_api_endpoint_to_display_directives_based_on_a_technique
branch
from
43aa519
to
536aec0
Compare
| } | ||
|
|
||
| def listDirectives (techniqueName : TechniqueName, wantedVersions: Option[List[TechniqueVersion]]) : Box[JValue] = { | ||
| def serializeDirectives (directives : Seq[Directive], techniques : SortedMap[TechniqueVersion, Technique]) = { |
There was a problem hiding this comment.
I don't like having closed parameters used in subfunction. It's harder to refactor, and closure leaks all around in scala. Could you add the wantedVersions parameter to parameters of serializeDirectives?
|
Appart for the cosmetic remarks, it's ok: you can mark it as mergeable when ready! |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8534/add_an_technique_api_endpoint_to_display_directives_based_on_a_technique
branch
from
536aec0
to
02f0dca
Compare
|
This PR is not mergeable to upper versions. |
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/8534