Fixes #8563: Make the search bar in menu able to also search rule, group, directive, etc #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
c79dee1
to
48be9ed
Compare
| // only search if query is on Directives and attributes contains | ||
| // DirectiveId, DirectiveVarName, DirectiveVarValue, TechniqueName, TechniqueVersion | ||
|
|
||
| val attributes: Set[QSAttribute] = query.attributes.intersect(QSObject.Directive.attributes) |
There was a problem hiding this comment.
QSObject.Directive can be replaced by QSDirective
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
4400edb
to
8accb18
Compare
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
8accb18
to
f1658ad
Compare
| * (just enabled/disabled with the parsing) | ||
| */ | ||
| sealed trait FeatureSwitch { def name: String } | ||
| object FeatureSwitch { |
There was a problem hiding this comment.
Use the implementation from PR #1141
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
2 times, most recently
from
c1245c2
to
08b68e1
Compare
|
PR rebased |
1 similar comment
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
08b68e1
to
610db0c
Compare
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
610db0c
to
743fe2e
Compare
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
743fe2e
to
5d7083c
Compare
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
5d7083c
to
75fa5f2
Compare
…up, directives...
|
PR rebased |
fanf
force-pushed
the
ust_8563/make_the_search_bar_in_menu_able_to_also_search_rule_group_directive_etc
branch
from
75fa5f2
to
11a3a35
Compare
|
PR rebased |
|
Replaced by #1188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8563
This is a work in progress with the current prototype, to allow some pre-validation (try the feature by yourself!) and looking to the code for architecture remarks.