Fixes #8785: Improve Script field behavior in passwords #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $scope.$watch('action',updateResult); | ||
| $scope.$watch('newPassword.password',updateResult); | ||
| $scope.$watch('newPassword.hash',updateResult); | ||
|
|
||
| function updateResult () { | ||
| // Keep and delete, use current password as base | ||
| var result = $scope.current | ||
| var result = angular.copy($scope.current) |
|
Appart from the two missing ;, this is awesome |
|
I've been testing it, and when we fill a password value, then click "add another", the field is emptied (looks like all the password fields get back their original value in this case) |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8785/improve_script_field_behavior_in_passwords
branch
from
6d1f502
to
99b5b30
Compare
|
Awesome! |
|
This is good for me (except the missing ; ) |
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8785/improve_script_field_behavior_in_passwords
branch
from
99b5b30
to
5ad4c2e
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_8785/improve_script_field_behavior_in_passwords
branch
from
5ad4c2e
to
41a18ac
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8785