Fixes #8985: Add node key in managed_nodes system variable #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
fanf
force-pushed
the
arch_8985/add_node_key_in_managed_nodes_system_variable
branch
from
ef5d002
to
8b3ef23
Compare
|
PR rebased |
fanf
force-pushed
the
arch_8985/add_node_key_in_managed_nodes_system_variable
branch
from
8b3ef23
to
e53fb08
Compare
ncharles
requested changes
Oct 4, 2016
|
|
||
| //the parser able to read PEM files | ||
| val parser = new PEMParser(new StringReader(key.value)) | ||
|
|
There was a problem hiding this comment.
There are a lot of asInstanceOf - shouldn't you wrap it around a try to catch casting exception ?
There was a problem hiding this comment.
They are already with tryo - which one did I missed ?
There was a problem hiding this comment.
huh - i didn't see any of them ... don't know why
It does look ok then
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8985