-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #8985: Add node key in managed_nodes system variable #1226
Fixes #8985: Add node key in managed_nodes system variable #1226
Conversation
PR rebased |
ef5d002
to
8b3ef23
Compare
PR rebased |
8b3ef23
to
e53fb08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
However, as you stated, there are a lot of casting - and I feel you should guard them around a try { } block
|
||
//the parser able to read PEM files | ||
val parser = new PEMParser(new StringReader(key.value)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of asInstanceOf - shouldn't you wrap it around a try to catch casting exception ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are already with tryo - which one did I missed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh - i didn't see any of them ... don't know why
It does look ok then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/8985