Fixes #9201: Add basic infrastructure to test REST API #1227
Conversation
fanf
force-pushed
the
arch_9201/add_basic_infrastructure_to_test_rest_api
branch
from
bc845df
to
198c550
Compare
|
PR rebased |
| method: GET | ||
| url: /api/techniqueLibrary/reload | ||
| response: | ||
| type: plop |
There was a problem hiding this comment.
Are you sure you want this type ?
There was a problem hiding this comment.
Yes, I wanted to test parsing error.
For now, the behaviour is to log:
[2016-11-15 11:33:32] ERROR com.normation.rudder.web.rest.TestRestFromFileDef - I wasn't able to run the 2th tests in file api/api_v1.yml <- The YAML document is empty
[2016-11-15 11:33:33] ERROR com.normation.rudder.web.rest.TestRestFromFileDef - I wasn't able to run the 1th tests in file api/api_v2.yml <- Unrecognized response type: 'plop'. Use 'json' or 'text'
And the test is not run. Would you find better to also fail the test? Effectively, it could be easier to correct all problems when we will change the format.
There was a problem hiding this comment.
Ok, it's better to have failing tests, but now I can't commit them because they will fails the test... not sur how to handle that.
|
|
||
|
|
||
| def GET(path: String) = { | ||
| val mockReq = new MockHttpServletRequest("http://localhost:8080") |
There was a problem hiding this comment.
probably nitpicking, but if jetty listen on another port, it will fail
we should probably use the defined port for jetty if available.
But that's probably for a future PR
There was a problem hiding this comment.
AFAIK, the server/port is only used to build the fake Request/Response, not to actually send anything on that URL. It could be anything, I believe.
| /* | ||
| * I *love* java. The snakeyaml parser returns a list of Objects. The may be null if empty, or | ||
| * others things. We don't know what other things. So I believe we just hope and cast to | ||
| * a Map[String, Object]. Which not much better. Expects other cast along the line. |
|
PR rebased |
fanf
force-pushed
the
arch_9201/add_basic_infrastructure_to_test_rest_api
branch
from
198c550
to
4526264
Compare
|
OK, merging this PR |
https://www.rudder-project.org/redmine/issues/9201