Fixes #9258: Rename to audit instead of verify in backend #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Oct 7, 2016
| @@ -354,6 +353,7 @@ class ReportsJdbcRepository(doobie: Doobie) extends ReportsRepository with Logga | |||
| //actual logic for getReportsfromId | |||
| (for { | |||
| toId <- getMaxId(lastProcessedId, endDate) | |||
| _ = logger.info("plop") | |||
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9258/rename_to_audit_instead_of_verify_in_backend
branch
from
e9f33ae
to
9fce28d
Compare
fanf
reviewed
Oct 7, 2016
| val none = None | ||
|
|
||
| "d1 == enforce, d2 == enforce => enforce" in { mode(enforce, enforce) must beEqualTo(Enforce) } | ||
| "d1 == enforce, d2 == none => enforce" in { mode(enforce, none ) must beEqualTo(Enforce) } | ||
| "d1 == enforce, d2 == audit => failure" in { mode(enforce, audit ) must haveClass[Failure] } | ||
| "d1 == audit , d2 == enforce => failure" in { mode(audit , enforce) must haveClass[Failure] } | ||
| "d1 == audit , d2 == audit => audit" in { mode(audit , audit ) must beEqualTo(Verify ) } | ||
| "d1 == audit , d2 == audit => audit" in { mode(audit , audit ) must beEqualTo(Audit ) } |
There was a problem hiding this comment.
Arg. Missing space. All the nice valign broken :((
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9258/rename_to_audit_instead_of_verify_in_backend
branch
from
9fce28d
to
437caef
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9258