Fixes #9290: Add an API endpoint to call rudder-remote-run #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9290/add_an_api_endpoint_to_call_rudder_remote_run
branch
from
e0775d7
to
e60647d
Compare
fanf
reviewed
Oct 14, 2016
|
|
||
| } catch { | ||
| case e : IOException => | ||
| // should we log ? Should we end ? |
There was a problem hiding this comment.
You can't do that, or you will leak ressource. The best way to handle that is to let the exception throws here, and manages it above. As your method is only used locally, it's ok. So remove try/catch here.
fanf
reviewed
Oct 14, 2016
| pb.setProcessListener(handler) | ||
| pb.start(); | ||
|
|
||
| runResponse(in) |
There was a problem hiding this comment.
Here, add a try catch, and on exception, close all the open resources: in, out
|
Commit modified |
VinceMacBuche
force-pushed
the
ust_9290/add_an_api_endpoint_to_call_rudder_remote_run
branch
from
e60647d
to
cf02f06
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9290