Fixes #9458: Invalid display in compliance for non-compliant report: shows "Not applicable" when not compliance #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Oct 19, 2016
| @@ -104,13 +104,17 @@ object ReportType { | |||
| case (_, BadPolicyMode) | (BadPolicyMode, _) => BadPolicyMode | |||
There was a problem hiding this comment.
You will have to change the start case above to AuditNotApplicable, else we will always get EnforceNotApplicable for them
There was a problem hiding this comment.
ha, i'm not sure I want to have by default the auditnotapplicable
Can i simply switch the last two lines ?
…shows \"Not applicable\" when not compliance
|
Commit modified |
ncharles
force-pushed
the
bug_9458/invalid_display_in_compliance_for_non_compliant_report_shows_not_applicable_when_not_compliance
branch
from
2c98c34
to
a3837d3
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9458